Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ios/android): update plugin code to player_id and player_name #15

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

PaulPaulDevelops
Copy link
Member

Description

Implemented the updates in order for the plugin code to resolve with the information the app needs upon sign-in, such as information on the user (for now, player_id and player_name ... but easily can add to this!)

On the iOS side, I ended up consolidating the existing code that already was fetching this information; I just made sure it was set in the call.resolve

On the Android side, this was a bit more tricky and did rework here in order to enhance the current signIn logic. I created callbacks for success and error for the signIn method (so we can send error information as well to the app). In the success, I called a new function that fetches getCurrentPlayer... which also has its own success/error callback.
The information provided from that new function is sent with the call.resolve

Note: Originally I was working with merged in changes from #14, but backed them out in order to have these changes be on their own this PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation Update (JS Docs)

General Checklist (every PR)

Please CHECK the box you took the step! Otherwise review should assume you missed it and fail the PR

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@PaulPaulDevelops
Copy link
Member Author

Doing brief final checks locally using the Rock The Steps app as an example project.
@Ricardo385 @emmanuelOpenForge @jedihacks

@PaulPaulDevelops PaulPaulDevelops marked this pull request as ready for review September 29, 2023 22:32
@PaulPaulDevelops
Copy link
Member Author

Confirmed on testing, marking ready for review!
@Ricardo385 @emmanuelOpenForge @jedihacks

Copy link
Collaborator

@Ricardo385 Ricardo385 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee!

@Ricardo385 Ricardo385 merged commit c4315c6 into main Oct 3, 2023
@Ricardo385 Ricardo385 deleted the feat/sign-in-information branch October 3, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants